Add Ray Message #125
Open
Add Ray Message #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igin and direction.
|
This looks like a reasonable message definition. Can you point to places using this or a similar message for example use cases to show that in it's current form it will be useful. Are there equivalent datatypes in use in other geometry libraries? And do you have converter and transform operations that could be added to tf2_geometry_msgs to support it? |
tfoote
reviewed
Oct 16, 2018
| @@ -0,0 +1,3 @@ | |||
| # A representation of a ray in 3-space, composed of an origin and a direction | |||
| Point origin | |||
| Vector3 direction | |||
There was a problem hiding this comment.
Suggested change
| Vector3 direction | |
| Quaternion direction |
A direction cannot have magnitude, but a Vector3 does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is publishing user mouse clicks in Rviz to external ROS nodes. Didn't find a standard message for a ray, so I here I am.